linux-kernel - Re: [PATCH v2] hv_sock: Add the support of hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201909271231.iD9JBAQs%lkp@intel.com>
Date:   Fri, 27 Sep 2019 12:18:35 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Dexuan Cui <decui@...rosoft.com>
Cc:     kbuild-all@...org, KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michael Kelley <mikelley@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>
Subject: Re: [PATCH v2] hv_sock: Add the support of hibernation

Hi Dexuan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[cannot apply to v5.3 next-20190925]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Dexuan-Cui/hv_sock-Add-the-support-of-hibernation/20190926-053950
config: x86_64-rhel-7.6 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

>> net//vmw_vsock/hyperv_transport.c:970:3: error: 'struct hv_driver' has no member named 'suspend'
     .suspend = hvs_suspend,
      ^~~~~~~
>> net//vmw_vsock/hyperv_transport.c:970:13: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
     .suspend = hvs_suspend,
                ^~~~~~~~~~~
   net//vmw_vsock/hyperv_transport.c:970:13: note: (near initialization for 'hvs_drv.shutdown')
>> net//vmw_vsock/hyperv_transport.c:971:3: error: 'struct hv_driver' has no member named 'resume'; did you mean 'remove'?
     .resume  = hvs_resume,
      ^~~~~~
      remove
>> net//vmw_vsock/hyperv_transport.c:971:13: warning: excess elements in struct initializer
     .resume  = hvs_resume,
                ^~~~~~~~~~
   net//vmw_vsock/hyperv_transport.c:971:13: note: (near initialization for 'hvs_drv')
   cc1: some warnings being treated as errors

vim +970 net//vmw_vsock/hyperv_transport.c

   963	
   964	static struct hv_driver hvs_drv = {
   965		.name		= "hv_sock",
   966		.hvsock		= true,
   967		.id_table	= id_table,
   968		.probe		= hvs_probe,
   969		.remove		= hvs_remove,
 > 970		.suspend	= hvs_suspend,
 > 971		.resume		= hvs_resume,
   972	};
   973	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (48067 bytes)