[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190930144958.GA42880@e119886-lin.cambridge.arm.com>
Date: Mon, 30 Sep 2019 15:49:59 +0100
From: Andrew Murray <andrew.murray@....com>
To: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Cc: Remi Pommarel <repk@...plefau.lt>,
Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] PCI: aardvark: Don't rely on jiffies while holding
spinlock
On Fri, Sep 27, 2019 at 11:45:55AM +0200, Thomas Petazzoni wrote:
> On Fri, 27 Sep 2019 10:55:02 +0200
> Remi Pommarel <repk@...plefau.lt> wrote:
>
> > advk_pcie_wait_pio() can be called while holding a spinlock (from
> > pci_bus_read_config_dword()), then depends on jiffies in order to
> > timeout while polling on PIO state registers. In the case the PIO
> > transaction failed, the timeout will never happen and will also cause
> > the cpu to stall.
> >
> > This decrements a variable and wait instead of using jiffies.
> >
> > Signed-off-by: Remi Pommarel <repk@...plefau.lt>
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>
>
Reviewed-by: Andrew Murray <andrew.murray@....com>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Powered by blists - more mailing lists