| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20190930145042.GA29258@bogus>
Date: Mon, 30 Sep 2019 09:50:42 -0500
From: Rob Herring <robh@...nel.org>
To: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Cc: linus.walleij@...aro.org, mark.rutland@....com,
linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, andriy.shevchenko@...el.com,
qi-ming.wu@...el.com, yixin.zhu@...ux.intel.com,
cheol.yong.kim@...el.com
Subject: Re: [PATCH v1 2/2] dt-bindings: pinctrl: intel: Add for new SoC
On Thu, Sep 12, 2019 at 03:59:11PM +0800, Rahul Tanwar wrote:
> Add dt bindings document & include file for pinmux & GPIO controller driver of
> Intel Lightning Mountain SoC.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> ---
> .../bindings/pinctrl/intel,lgm-pinctrl.yaml | 131 +++++++++++++++++++++
> include/dt-bindings/pinctrl/intel,equilibrium.h | 23 ++++
> 2 files changed, 154 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml
> create mode 100644 include/dt-bindings/pinctrl/intel,equilibrium.h
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml
> new file mode 100644
> index 000000000000..1aee42f0057e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml
> @@ -0,0 +1,131 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/pinctrl/intel,lgm-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain SoC pinmux & GPIO controller binding
> +
> +maintainers:
> + - Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> +
> +description: |
> + Pinmux & GPIO controller controls pin multiplexing & configuration including
> + GPIO function selection & GPIO attributes configuration.
> +
> + Please refer to [1] for details of the common pinctrl bindings used by the
> + client devices.
> +
> + [1] Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt
> +
> +properties:
> + compatible:
> + const: intel,lgm-pinctrl
> +
> + reg:
> + maxItems: 1
> +
> +# Client device subnode's properties
> +patternProperties:
> + "^.*@[0-9a-fA-F]+$":
> + type: object
> + description:
> + Pinctrl node's client devices use subnodes for desired pin configuration.
> + Client device subnodes use below defined properties.
> +
> + properties:
> + intel,function:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + A string containing the name of the function to mux to the group.
> +
> + intel,groups:
> + $ref: /schemas/types.yaml#/definitions/string-array
> + description:
> + An array of strings identifying the list of groups.
> +
> + intel,pins:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
> + List of pins to select with this function.
> +
> + intel,mux:
> + description: The applicable mux group.
> + allOf:
> + - $ref: "/schemas/types.yaml#/definitions/uint32"
> + - enum:
> + # Refer include/dt-bindings/pinctrl/intel,equilibrium.h
> + - PINMUX_0 # 0 PINMUX_GPIO
> + - PINMUX_1 # 1
> + - PINMUX_2 # 2
> + - PINMUX_3 # 3
> + - PINMUX_4 # 4
> +
> + intel,pullup:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Specifies pull-up configuration.
> +
> + intel,pulldown:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Specifies pull-down configuration.
> +
> + intel,drive-current:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Enables driver-current.
> +
> + intel,slew-rate:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Enables slew-rate.
> +
> + intel,open-drain:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Specifies open-drain configuration.
> +
> + intel,output:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Specifies if the pin is to be configured as output.
We have a whole slew of standard properties for pinctrl and you aren't
using any of them.
Rob
> +
> +
> + required:
> + - intel,function
> + - intel,groups
> +
> +required:
> + - compatible
> + - reg
> +
> +examples:
> + # Pinmux controller node
> + - |
> + pinctrl: pinctrl@...80000 {
> + compatible = "intel,lgm-pinctrl";
> + reg = <0xe2880000 0x100000>;
> + };
> +
> + # Client device node
> + - |
These are not really separate examples.
> + asc0: serial@...00000 {
> + compatible = "intel,lgm-asc";
> + reg = <0xe0a00000 0x1000>;
> + interrupt-parent = <&ioapic1>;
> + interrupts = <128 1>;
> + interrupt-names = "asc_irq";
> + clocks = <&cgu0 31>, <&cgu0 98>;
> + clock-names = "freq", "asc";
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart0>;
> + };
> +
> + # Client device subnode
> + - |
> + uart0:uart0 {
This should be a child of pinctrl node.
> + intel,pins = <64>, /* UART_RX0 */
> + <65>; /* UART_TX0 */
> + intel,function = "CONSOLE_UART0";
> + intel,mux = <1>,
> + <1>;
> + intel,groups = "CONSOLE_UART0";
> + };
> +
> +
> +...
> diff --git a/include/dt-bindings/pinctrl/intel,equilibrium.h b/include/dt-bindings/pinctrl/intel,equilibrium.h
> new file mode 100644
> index 000000000000..c37bfbea8ff1
> --- /dev/null
> +++ b/include/dt-bindings/pinctrl/intel,equilibrium.h
> @@ -0,0 +1,23 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +
> +#ifndef __DT_BINDINGS_PINCTRL_INTEL_EQUILIBRIUM_H_
> +#define __DT_BINDINGS_PINCTRL_INTEL_EQUILIBRIUM_H_
> +
> +#define PINCTRL_DRCC_2_MA 0
> +#define PINCTRL_DRCC_4_MA 1
> +#define PINCTRL_DRCC_8_MA 2
> +#define PINCTRL_DRCC_12_MA 3
Use the property that defines drive strength in terms of microamps and
convert to register values in the driver.
> +
> +#define PINMUX_0 0
> +#define PINMUX_1 1
> +#define PINMUX_2 2
> +#define PINMUX_3 3
> +#define PINMUX_4 4
Not useful defines. Just use the numbers directly.
> +#define PINMUX_GPIO PINMUX_0
> +
> +#define PINCTRL_GROUP "intel,groups"
> +#define PINCTRL_FUNCTION "intel,function"
> +#define PINCTRL_PINS "intel,pins"
> +#define PINCTRL_MUX "intel,mux"
We don't create defines for property names (really for any strings).
> +
> +#endif /* __DT_BINDINGS_PINCTRL_INTEL_EQUILIBRIUM_H_ */
> --
> 2.11.0
>
Powered by blists - more mailing lists