linux-kernel - Re: [PATCH] lightnvm: prevent memory leak in nvm_bb_chunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d44a6dca-006e-5bcc-64b4-2b62cf9a9769@web.de>
Date:   Mon, 30 Sep 2019 09:16:30 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Navid Emamdoost <navid.emamdoost@...il.com>,
        linux-block@...r.kernel.org
Cc:     Navid Emamdoost <emamd001@....edu>, Kangjie Lu <kjlu@....edu>,
        Stephen McCamant <smccaman@....edu>,
        Matias Bjorling <mb@...htnvm.io>, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] lightnvm: prevent memory leak in nvm_bb_chunk_sense

> To fix this issue I moved the __free_page call before error check.

Would the wording “Move the __free_page() call before the error check.”
be more succinct for the change description?

Can the following code variant be applied at the end of this function?

 	return ret ? ret : rqd.error;

Regards,
Markus