linux-kernel - Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap of LFS curseg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43edc2f2-5b42-0cd7-1573-af77fd9e6678@huawei.com>
Date:   Mon, 30 Sep 2019 15:36:16 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Pavel Machek <pavel@....cz>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <linux-kernel@...r.kernel.org>, <stable@...r.kernel.org>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 4.19 53/63] f2fs: fix to do sanity check on segment bitmap
 of LFS curseg

Hello,

On 2019/9/30 15:21, Pavel Machek wrote:
> Hi!
> 
> 
>> +		for (blkofs += 1; blkofs < sbi->blocks_per_seg; blkofs++) {
>> +			if (!f2fs_test_bit(blkofs, se->cur_valid_map))
>> +				continue;
>> +out:
>> +			f2fs_msg(sbi->sb, KERN_ERR,
>> +				"Current segment's next free block offset is "
>> +				"inconsistent with bitmap, logtype:%u, "
>> +				"segno:%u, type:%u, next_blkoff:%u, blkofs:%u",
>> +				i, curseg->segno, curseg->alloc_type,
>> +				curseg->next_blkoff, blkofs);
>> +			return -EINVAL;
>> +		}
> 
> So this is detecting filesystem corruption, right? Should it be
> -EUCLEAN?

Was fixed in another commit 10f966bbf521 ("f2fs: use generic
EFSBADCRC/EFSCORRUPTED"). :)

Thanks,

> 
> 									Pavel
>