linux-kernel - Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after calling of_get_child_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191001.100341.1797056721948216269.davem@davemloft.net>
Date:   Tue, 01 Oct 2019 10:03:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     wenyang@...ux.alibaba.com
Cc:     linus.walleij@...aro.org, xlpang@...ux.alibaba.com,
        zhiche.yy@...baba-inc.com, andrew@...n.ch,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: rtl8366rb: add missing of_node_put after
 calling of_get_child_by_name

From: Wen Yang <wenyang@...ux.alibaba.com>
Date: Sun, 29 Sep 2019 15:00:47 +0800

> of_node_put needs to be called when the device node which is got
> from of_get_child_by_name finished using.
> irq_domain_add_linear() also calls of_node_get() to increase refcount,
> so irq_domain will not be affected when it is released.
> 
> fixes: d8652956cf37 ("net: dsa: realtek-smi: Add Realtek SMI driver")
> Signed-off-by: Wen Yang <wenyang@...ux.alibaba.com>

Please capitalize Fixes:, seriously I am very curious where did you
learned to specify the fixes tag non-capitalized?

Patch applied, t hanks.