linux-kernel - Re: [PATCH 0/4] USB: fix runtime PM after driver unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191001082322.GH13531@localhost>
Date:   Tue, 1 Oct 2019 10:23:22 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Pete Zaitcev <zaitcev@...hat.com>,
        Alan Stern <stern@...land.harvard.edu>,
        linux-media@...r.kernel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] USB: fix runtime PM after driver unbind

On Mon, Sep 30, 2019 at 01:36:03PM -0300, Mauro Carvalho Chehab wrote:
> Em Mon, 30 Sep 2019 18:12:01 +0200
> Johan Hovold <johan@...nel.org> escreveu:
> 
> > A recent change in USB core broke runtime-PM after driver unbind in
> > several drivers (when counting all USB serial drivers). Specifically,
> > drivers which took care not modify the runtime-PM usage counter after
> > their disconnect callback had returned, would now fail to be suspended
> > when a driver is later bound.
> > 
> > I guess Greg could take all of these directly through his tree, unless
> > the media maintainers disagree.
> 
> Patches look ok and I'm fine if they go via Greg's tree. So:
> 
> Acked-by: Mauro Carvalho Chehab <mchehab+samsung@...nel.org>

Thanks for taking a look.

> Yet, on a quick look on media:
> 
> 	$ git grep -l usb_.*pm drivers/media/usb/
> 	drivers/media/usb/cpia2/cpia2_usb.c
> 	drivers/media/usb/dvb-usb-v2/az6007.c
> 	drivers/media/usb/dvb-usb-v2/dvb_usb.h
> 	drivers/media/usb/dvb-usb-v2/dvb_usb_core.c
> 	drivers/media/usb/gspca/gspca.c
> 	drivers/media/usb/gspca/gspca.h
> 	drivers/media/usb/siano/smsusb.c
> 	drivers/media/usb/stkwebcam/stk-webcam.c
> 	drivers/media/usb/usbvision/usbvision-i2c.c
> 	drivers/media/usb/uvc/uvc_driver.c
> 	drivers/media/usb/uvc/uvc_v4l2.c
> 	drivers/media/usb/zr364xx/zr364xx.c
> 
> There are other drivers beside stkwebcam with has some PM routines.

Yeah, but that may be for system-wide suspend.

> Ok, only two (stkwebcam and uvcvideo) uses usb_autopm_get_interface() and
> usb_autopm_put_interface(), but I'm wondering if the others are doing the
> right thing, as their implementation are probably older.

Right, only these two support runtime PM through USB core (autosuspend).

In fact, I see now that stkwebcam fails to set the supports_autosuspend
flag in its usb_driver struct, so runtime PM has never actually been
enabled for this driver either. But I guess it doesn't hurt to fix
missing puts if someones wants to try enabling it, if not only for
documentation purposes and avoiding copy-paste proliferation.

Lots of legacy...

Johan