linux-kernel - Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191001131717.GD22609@kadam>
Date:   Tue, 1 Oct 2019 16:17:17 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jesse Barton <jessebarton95@...il.com>
Cc:     valdis.kletnieks@...edu, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style
 issues.

On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote:
> Fixed Coding Style issues

Which ones?

> 
> Signed-off-by: Jesse Barton <jessebarton95@...il.com>
> ---
>  drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
>  1 file changed, 9 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 3c7e2b7c2195..b9656ec06144 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
>  	return ret;
>  }
>  
> -static int ffs_create_file(struct inode *inode, char *path, u8 mode,
> -			 struct file_id_t *fid)
> +static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)

I think now checkpatch will complain that the line is too long?  What we
want here is:

static int ffs_create_file(struct inode *inode, char *path, u8 mode,
			   struct file_id_t *fid)

[tab][tab][tab][space][space][space]struct file_id_t *fid)

So they line up.

regards,
dan carpenter