linux-kernel - Re: [Cocci] [RFC] scripts: Fix coccicheck failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15b52ec6-1cb4-f419-351a-07241cdb8674@web.de>
Date:   Tue, 1 Oct 2019 17:33:47 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Matthias Maennich <maennich@...gle.com>,
        Yue Haibing <yuehaibing@...wei.com>,
        Coccinelle <cocci@...teme.lip6.fr>,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jessica Yu <jeyu@...nel.org>,
        Martijn Coenen <maco@...roid.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>
Subject: Re: [Cocci] [RFC] scripts: Fix coccicheck failed

> >+virtual report
> >+
> > @has_ns_import@
> > declarer name MODULE_IMPORT_NS;
> > identifier virtual.ns;
> >
> >Adding virtual report make the coccicheck go ahead smoothly.

Such an adjustment might be an interesting solution.


> Thanks for reporting and following up with this issue. I certainly did
> not expect all scripts in scripts/coccinelle to be automatically called
> by coccicheck

Did you (or any other contributor) test the collaboration of the added
small SmPL file with the known call interface?


> and I still think scripts/coccinelle is the right location
> for add_namespace.cocci.

I got additional software development ideas around this view in the meantime.
Would you like to take any other collateral evolution better into account?

Regards,
Markus