linux-kernel - [PATCH] eeprom: Warn that the driver is deprecated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20191002104844.1dc4d8f3@endymion>
Date:   Wed, 2 Oct 2019 10:48:44 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] eeprom: Warn that the driver is deprecated

Deprecating the driver in Kconfig is one thing, but we also need to
let the users themselves know. Log a warning each time a device is
bound to the deprecated eeprom driver.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Arnd Bergmann <arnd@...db.de>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
 drivers/misc/eeprom/eeprom.c |    4 ++++
 1 file changed, 4 insertions(+)

--- linux-5.2.orig/drivers/misc/eeprom/eeprom.c	2019-07-08 00:41:56.000000000 +0200
+++ linux-5.2/drivers/misc/eeprom/eeprom.c	2019-10-02 10:46:23.363974060 +0200
@@ -175,6 +175,10 @@ static int eeprom_probe(struct i2c_clien
 		}
 	}
 
+	/* Let the users know they are using deprecated driver */
+	dev_notice(&client->dev,
+		   "eeprom driver is deprecated, please use at24 instead\n");
+
 	/* create the sysfs eeprom file */
 	return sysfs_create_bin_file(&client->dev.kobj, &eeprom_attr);
 }


-- 
Jean Delvare
SUSE L3 Support