linux-kernel - Re: [PATCH v3 2/4] x86/kvm: Change print code to use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7d2623a-c6a6-cd68-5b8e-ed37a0cc9178@oracle.com>
Date:   Thu, 3 Oct 2019 18:32:08 +0800
From:   Zhenzhong Duan <zhenzhong.duan@...cle.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     linux-kernel@...r.kernel.org, vkuznets@...hat.com,
        linux-hyperv@...r.kernel.org, kvm@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krcmar <rkrcmar@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v3 2/4] x86/kvm: Change print code to use pr_*() format

On 2019/10/3 1:15, Sean Christopherson wrote:

> On Mon, Sep 30, 2019 at 08:44:37PM +0800, Zhenzhong Duan wrote:
>> pr_*() is preferred than printk(KERN_* ...), after change all the print
>> in arch/x86/kernel/kvm.c will have "KVM: xxx" style.
>>
>> No functional change.
>>
>> Suggested-by: Vitaly Kuznetsov<vkuznets@...hat.com>
> This wasn't really suggested by Vitaly, he just requested it be done in a
> separate patch.

Will fix.

>
>> Signed-off-by: Zhenzhong Duan<zhenzhong.duan@...cle.com>
>> Cc: Paolo Bonzini<pbonzini@...hat.com>
>> Cc: Radim Krcmar<rkrcmar@...hat.com>
>> Cc: Sean Christopherson<sean.j.christopherson@...el.com>
>> Cc: Vitaly Kuznetsov<vkuznets@...hat.com>
>> Cc: Wanpeng Li<wanpengli@...cent.com>
>> Cc: Jim Mattson<jmattson@...gle.com>
>> Cc: Joerg Roedel<joro@...tes.org>
>> Cc: Thomas Gleixner<tglx@...utronix.de>
>> Cc: Ingo Molnar<mingo@...hat.com>
>> Cc: Borislav Petkov<bp@...en8.de>
>> Cc: "H. Peter Anvin"<hpa@...or.com>
>> ---
>>   arch/x86/kernel/kvm.c | 24 ++++++++++++------------
>>   1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
>> index a4f108d..ce4f578 100644
>> --- a/arch/x86/kernel/kvm.c
>> +++ b/arch/x86/kernel/kvm.c
>> @@ -7,6 +7,8 @@
>>    *   Authors: Anthony Liguori<aliguori@...ibm.com>
>>    */
>>   
>> +#define pr_fmt(fmt) "KVM: " fmt
> Not a fan of "KVM" as the prefix as it's easily confused with KVM the
> hypervisor.  Maybe "kvm_guest"?

Yeah, looks better, will change to"kvm_guest". Thanks

Zhenzhong