[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cbfb13ec-bd0c-d9df-e61e-8a08f2c9f526@oracle.com>
Date: Thu, 3 Oct 2019 19:21:11 +0800
From: Zhenzhong Duan <zhenzhong.duan@...cle.com>
To: Sean Christopherson <sean.j.christopherson@...el.com>
Cc: linux-kernel@...r.kernel.org, vkuznets@...hat.com,
linux-hyperv@...r.kernel.org, kvm@...r.kernel.org,
Jonathan Corbet <corbet@....net>,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Juergen Gross <jgross@...e.com>,
Stefano Stabellini <sstabellini@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v3 3/4] xen: Mark "xen_nopvspin" parameter obsolete and
map it to "nopvspin"
On 2019/10/3 1:18, Sean Christopherson wrote:
> On Mon, Sep 30, 2019 at 08:44:38PM +0800, Zhenzhong Duan wrote:
>> Fix stale description of "xen_nopvspin" as we use qspinlock now.
>>
>> Signed-off-by: Zhenzhong Duan<zhenzhong.duan@...cle.com>
>> Reviewed-by: Juergen Gross<jgross@...e.com>
>> Cc: Jonathan Corbet<corbet@....net>
>> Cc: Boris Ostrovsky<boris.ostrovsky@...cle.com>
>> Cc: Juergen Gross<jgross@...e.com>
>> Cc: Stefano Stabellini<sstabellini@...nel.org>
>> Cc: Thomas Gleixner<tglx@...utronix.de>
>> Cc: Ingo Molnar<mingo@...hat.com>
>> Cc: Borislav Petkov<bp@...en8.de>
>> Cc: "H. Peter Anvin"<hpa@...or.com>
>> ---
...snip
>> @@ -93,7 +92,7 @@ void xen_init_lock_cpu(int cpu)
>>
>> void xen_uninit_lock_cpu(int cpu)
>> {
>> - if (!xen_pvspin)
>> + if (!pvspin)
>> return;
>>
>> unbind_from_irqhandler(per_cpu(lock_kicker_irq, cpu), NULL);
>> @@ -117,9 +116,9 @@ void __init xen_init_spinlocks(void)
>>
>> /* Don't need to use pvqspinlock code if there is only 1 vCPU. */
>> if (num_possible_cpus() == 1)
>> - xen_pvspin = false;
>> + pvspin = false;
> As suggested in the other patch, if you incorporate pvspin (or nopvspin)
> into xen_pvspin then the param can be __initdata and the diff for this
> patch will be smaller, e.g. you wouldn't need the xen_domain() shenanigans
> in xen_parse_nopvspin().
Ok, will fix. Thanks
Zhenzhong
Powered by blists - more mailing lists