linux-kernel - Re: [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191004105902.GM896@valkosipuli.retiisi.org.uk>
Date:   Fri, 4 Oct 2019 13:59:02 +0300
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     mchehab@...nel.org, robh+dt@...nel.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        c.barrett@...mos.com, a.brela@...mos.com
Subject: Re: [PATCH v4 2/2] media: i2c: Add IMX290 CMOS image sensor driver

Hi Manivannan,

On Fri, Oct 04, 2019 at 03:49:02PM +0530, Manivannan Sadhasivam wrote:
> Hi Sakari,
> 
> On Fri, Oct 04, 2019 at 12:23:36PM +0300, Sakari Ailus wrote:
> > Hi Manivannan,
> > 
> > On Thu, Oct 03, 2019 at 03:25:03PM +0530, Manivannan Sadhasivam wrote:
> > > Add driver for Sony IMX290 CMOS image sensor driver. The driver only
> > > supports I2C interface for programming and MIPI CSI-2 for sensor output.
> > > 
> > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> > 
> > Could you remove the unneeded ret variable from imx290_power_on() and
> > unneeded goto in the same function?
> >
> 
> yep, sure.
>  
> > The MAINTAINERS entry belongs to the first patch adding new files.
> > 
> 
> You mean the bindings patch? If then, sorry no. Usually the devicetree bindings
> belongs to a separate patch and that is what perferred by Rob. I prefer the
> MAINTAINERS entry in a separate patch but I've seen subsystems maintainers
> asking to squash it with the driver patch. But squashing it with bindings
> patch seems weird to me.

This has been an established practice at least in the media tree. The
MAINTAINERS change is small, and bindings come before the driver. And the
MAINTAINERS change needs to come no later than files are being added, or a
checkpatch.pl warning follows --- which is entirely reasonable. You could
put the MAINTAINERS change to a separate patch, yes, but I personally think
it fits fine with the DT binding patch.

-- 
Regards,

Sakari Ailus