linux-kernel - Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <969729ce-6246-6fa7-45c9-3dd9cb07059d@huawei.com>
Date:   Fri, 4 Oct 2019 15:59:44 +0100
From:   John Garry <john.garry@...wei.com>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
CC:     <peterz@...radead.org>, <mingo@...hat.com>,
        <alexander.shishkin@...ux.intel.com>, <jolsa@...hat.com>,
        <namhyung@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <will@...nel.org>, <mark.rutland@....com>,
        <zhangshaokun@...ilicon.com>, James Clark <James.Clark@....com>
Subject: Re: [PATCH 0/4] HiSilicon hip08 uncore PMU events additions

On 04/10/2019 15:38, Arnaldo Carvalho de Melo wrote:
> Em Fri, Oct 04, 2019 at 11:36:58AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Oct 04, 2019 at 03:30:07PM +0100, John Garry escreveu:
>>> On 04/09/2019 16:54, John Garry wrote:
>>>> This patchset adds some missing uncore PMU events for the hip08 arm64
>>>> platform.
>>>>
>>>> The missing events were originally mentioned in
>>>> https://lkml.org/lkml/2019/6/14/645, when upstreaming the JSONs initially.
>>>>
>>>> It also includes a fix for a DDRC eventname.
>>>
>>> Hi guys,
>>>
>>> Could I get these JSON updates picked up please? Maybe they were missed
>>> earlier. Let me know if I should re-post.
>>
>> Looking at them now.
>
> It would be really good if somehow we managed to have someone from the
> ARM community to check and provide a Reviewed-by for those, i.e. someone
> else than the poster to look at it and check that its ok, would that be
> possible?

Hi Arnaldo,

For this specific case, I'm not sure how much traction or value there 
would be since we're just adding some missing events for custom IP.

But I do agree that more review of JSONs from the community is required 
- as I brought up here regarding a recent addition: 
https://lore.kernel.org/lkml/749a0b8e-2bfd-28f6-b34d-dc72ef3d3a74@huawei.com/

Can we enforce that at least linux-arm-kernel@...ts.infradead.org and/or 
get_maintainer.pl results is cc'ed on anything ARM specific as a start?

Cheers,
John

>
> - Arnaldo
>
>> - Arnaldo
>>
>>> Thanks in advance,
>>> John
>>>
>>>>
>>>> John Garry (4):
>>>>   perf jevents: Fix Hisi hip08 DDRC PMU eventname
>>>>   perf jevents: Add some missing events for Hisi hip08 DDRC PMU
>>>>   perf jevents: Add some missing events for Hisi hip08 L3C PMU
>>>>   perf jevents: Add some missing events for Hisi hip08 HHA PMU
>>>>
>>>>  .../arm64/hisilicon/hip08/uncore-ddrc.json    | 16 +++++-
>>>>  .../arm64/hisilicon/hip08/uncore-hha.json     | 23 +++++++-
>>>>  .../arm64/hisilicon/hip08/uncore-l3c.json     | 56 +++++++++++++++++++
>>>>  3 files changed, 93 insertions(+), 2 deletions(-)
>>>>
>>>
>>
>> --
>>
>> - Arnaldo
>