linux-kernel - Re: [PATCH] gfs2: removed unnecessary semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1944905967.4863703.1570204154537.JavaMail.zimbra@redhat.com>
Date:   Fri, 4 Oct 2019 11:49:14 -0400 (EDT)
From:   Bob Peterson <rpeterso@...hat.com>
To:     aliasgar surti500 <aliasgar.surti500@...il.com>
Cc:     agruenba@...hat.com, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gfs2: removed unnecessary semicolon

----- Original Message -----
> From: Aliasgar Surti <aliasgar.surti500@...il.com>
> 
> There is use of unnecessary semicolon after switch case.
> Removed the semicolon.
> 
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@...il.com>
> ---
>  fs/gfs2/recovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
> index c529f8749a89..f4aa8551277b 100644
> --- a/fs/gfs2/recovery.c
> +++ b/fs/gfs2/recovery.c
> @@ -326,7 +326,7 @@ void gfs2_recover_func(struct work_struct *work)
>  
>  		default:
>  			goto fail;
> -		};
> +		}
>  
>  		error = gfs2_glock_nq_init(ip->i_gl, LM_ST_SHARED,
>  					   LM_FLAG_NOEXP | GL_NOCACHE, &ji_gh);
> --
> 2.17.1

Hi,

Thanks for the patch. I did a quick search and found two more:

glops.c-                break;
glops.c:        };

inode.c-                        goto out_gunlock;
inode.c:                };

Do you want to include those in your patch and re-submit it or
should I cook up a second patch?

Regards,

Bob Peterson
Red Hat File Systems