linux-kernel - Re: [PATCH v7 5/5] backlight: add led-backlight driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Oct 2019 17:49:26 +0200
From:   Jean-Jacques Hiblot <jjhiblot@...com>
To:     Lee Jones <lee.jones@...aro.org>
CC:     <jacek.anaszewski@...il.com>, <pavel@....cz>, <robh+dt@...nel.org>,
        <mark.rutland@....com>, <daniel.thompson@...aro.org>,
        <dmurphy@...com>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <tomi.valkeinen@...com>
Subject: Re: [PATCH v7 5/5] backlight: add led-backlight driver

Hi Lee,

On 04/10/2019 16:39, Lee Jones wrote:
> On Wed, 18 Sep 2019, Jean-Jacques Hiblot wrote:
>
>> From: Tomi Valkeinen <tomi.valkeinen@...com>
>>
>> This patch adds a led-backlight driver (led_bl), which is similar to
>> pwm_bl except the driver uses a LED class driver to adjust the
>> brightness in the HW. Multiple LEDs can be used for a single backlight.
>>
>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@...com>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@...com>
>> Acked-by: Pavel Machek <pavel@....cz>
>> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
>> ---
>>   drivers/video/backlight/Kconfig  |   7 +
>>   drivers/video/backlight/Makefile |   1 +
>>   drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++
>>   3 files changed, 268 insertions(+)
>>   create mode 100644 drivers/video/backlight/led_bl.c
> Applied, thanks.

It will break the build because it relies on functions not yet in the 
LED core (devm_led_get() for v7 or devm_of_led_get() for v8)

JJ

>