linux-kernel - Re: [PATCH 2/3] KVM: x86: always expose VIRT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a15e4b77-22ca-e92d-b170-e40b845a5bd1@redhat.com>
Date:   Sun, 6 Oct 2019 18:08:24 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Eduardo Habkost <ehabkost@...hat.com>
Cc:     linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Jim Mattson <jmattson@...gle.com>, konrad.wilk@...cle.com
Subject: Re: [PATCH 2/3] KVM: x86: always expose VIRT_SSBD to guests

On 02/10/19 00:16, Eduardo Habkost wrote:
> Wasn't the old code at arch/x86/kvm/cpuid.c:__do_cpuid_func()
> supposed to be deleted?
> 
>                /*
>                 * The preference is to use SPEC CTRL MSR instead of the
>                 * VIRT_SPEC MSR.
>                 */
>                if (boot_cpu_has(X86_FEATURE_LS_CFG_SSBD) &&
>                    !boot_cpu_has(X86_FEATURE_AMD_SSBD))
>                        entry->ebx |= F(VIRT_SSBD);

Yeah, it's harmless but also useless.

Paolo