linux-kernel - Re: Potential NULL pointer deference in scsi: scsi_transport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1570481667.4242.4.camel@linux.ibm.com>
Date:   Mon, 07 Oct 2019 13:54:27 -0700
From:   James Bottomley <jejb@...ux.ibm.com>
To:     Yizhuo Zhai <yzhai003@....edu>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Chengyu Song <csong@...ucr.edu>,
        Zhiyun Qian <zhiyunq@...ucr.edu>
Subject: Re: Potential NULL pointer deference in scsi: scsi_transport_spi

On Mon, 2019-10-07 at 13:30 -0700, Yizhuo Zhai wrote:
> Hi All:
> 
> drivers/scsi/scsi_transport_spi.c:
> 
> Inside function store_spi_transport_period(), dev_to_shost()
> could return NULL

No, it can't.  The device model ensures that a SCSI target or device
must be parented to a host.

James

> , however, the return value shost is not
> checked and get used. This could potentially be unsafe.
>