linux-kernel - Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191007075712.GA5466@linux.intel.com>
Date:   Mon, 7 Oct 2019 10:57:12 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-sgx@...r.kernel.org, akpm@...ux-foundation.org,
        dave.hansen@...el.com, nhorman@...hat.com, npmccallum@...hat.com,
        serge.ayoun@...el.com, shay.katz-zamir@...el.com,
        haitao.huang@...el.com, andriy.shevchenko@...ux.intel.com,
        tglx@...utronix.de, kai.svahn@...el.com, bp@...en8.de,
        josh@...htriplett.org, luto@...nel.org, kai.huang@...el.com,
        rientjes@...gle.com, cedric.xing@...el.com,
        Andy Lutomirski <luto@...capital.net>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in
 vDSO functions

On Sat, Oct 05, 2019 at 08:54:13AM -0700, Sean Christopherson wrote:
> On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote:
> > > I'll tackle this tomorrow.  I've been working on the feature control MSR
> > > series and will get that sent out tomorrow as well.  I should also be able
> > > to get you the multi-page EADD patch.
> > 
> > Great I'll compose the patch set during the weekend and take Monday off
> > so you have the full work day to get everything (probably send the patch
> > set on Sunday).
> 
> Didn't get to the actual SGX stuff yesterday as the feature control series
> took longer than expected to finish.  Working on the other items this
> morning.

I anyway decided to wait for your patches.

I said in earlier email that two ioctl's would be great but I think the
following would be the API that I would actually appreciate the most:

struct sgx_enclave_add_page_desc {
	__u64	addr;
	__u64	src;
	__u64	secinfo;
	__u16	mrmask;
	__u8	reserved[6];
};

struct sgx_enclave_add_page {
	__u64	nr_pages;
	__u64	pages;
};

This will keep the same amount of control and give the performance
benefit. And it is trivial to use in the single page case. Finally,
it follows the principle of minimal delta i.e. we move the least from
the existing API, which is somewhat proven, to fulfill the new
requirement.

Can you use this model for the API? For internals you can choose what
you see fits best.

/Jarkko