linux-kernel - Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in vDSO functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191007080136.GB5466@linux.intel.com>
Date:   Mon, 7 Oct 2019 11:01:36 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sean Christopherson <sean.j.christopherson@...el.com>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-sgx@...r.kernel.org, akpm@...ux-foundation.org,
        dave.hansen@...el.com, nhorman@...hat.com, npmccallum@...hat.com,
        serge.ayoun@...el.com, shay.katz-zamir@...el.com,
        haitao.huang@...el.com, andriy.shevchenko@...ux.intel.com,
        tglx@...utronix.de, kai.svahn@...el.com, bp@...en8.de,
        josh@...htriplett.org, luto@...nel.org, kai.huang@...el.com,
        rientjes@...gle.com, cedric.xing@...el.com,
        Andy Lutomirski <luto@...capital.net>,
        Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH v22 16/24] x86/vdso: Add support for exception fixup in
 vDSO functions

On Sat, Oct 05, 2019 at 11:39:39AM -0700, Sean Christopherson wrote:
> On Fri, Oct 04, 2019 at 09:52:21PM +0300, Jarkko Sakkinen wrote:
> > On Thu, Oct 03, 2019 at 05:15:00PM -0700, Sean Christopherson wrote:
> > > I'll tackle this tomorrow.  I've been working on the feature control MSR
> > > series and will get that sent out tomorrow as well.  I should also be able
> > > to get you the multi-page EADD patch.
> > 
> > Great I'll compose the patch set during the weekend and take Monday off
> > so you have the full work day to get everything (probably send the patch
> > set on Sunday).
> 
> I wasn't able to finish everything this morning (not even close).  The
> vDSO code and documentation was in rough shape.  I finished cleaning it
> up, but still need to test and rewrite the changelog.
> 
> If you really want to send v23 this weekend I can work more tonight
> and/or tomorrow morning.  My preference would be to just punt a few more
> days.
> 
> My todo list for v23:
> 
>   - Test vDSO changes and craft proper patches
>   - Rewrite vDSO changelog
>   - Rewrite vDSO exception fixup changelog
>   - Implement multi-page EADD

For maintainer commit messages are at least as important as
documentation in the Documentation folder, if not more. If
they've been written well, they are useful when back tracking
history when fixing bugs and so forth.

> 
> My todo list post-v23:
>   - Write SGX programming model documentation (requested by Casey)

I'll wait up until I get your v23 changes. Try to get them as
fast as possible but without sacrificing quality.

/Jarkko