linux-kernel - Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for dpclk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191007123512.GM7150@dragon>
Date:   Mon, 7 Oct 2019 20:35:14 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Wen He <wen.he_1@....com>
Cc:     linux-devel@...ux.nxdi.nxp.com, Li Yang <leoyang.li@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [v2 2/2] arm64: dts: ls1028a: Update the DT node definition for
 dpclk

On Fri, Sep 20, 2019 at 04:34:19PM +0800, Wen He wrote:
> Update DT node name clock-controller to clock-display,

The node name clock-controller is so good, and I do not understand why
you need to change it.

Shawn

> also change
> the property #clock-cells value to zero.
> 
> This update according the feedback of the Display output interface
> clock driver upstream.
> 
> Link: https://lore.kernel.org/patchwork/patch/1113832/
> Signed-off-by: Wen He <wen.he_1@....com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> index 51fa8f57fdac..db1e186352d8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
> @@ -79,10 +79,10 @@
>  		clock-output-names = "phy_27m";
>  	};
>  
> -	dpclk: clock-controller@...0000 {
> +	dpclk: clock-display@...0000 {
>  		compatible = "fsl,ls1028a-plldig";
>  		reg = <0x0 0xf1f0000 0x0 0xffff>;
> -		#clock-cells = <1>;
> +		#clock-cells = <0>;
>  		clocks = <&osc_27m>;
>  	};
>  
> @@ -665,7 +665,7 @@
>  		interrupts = <0 222 IRQ_TYPE_LEVEL_HIGH>,
>  			     <0 223 IRQ_TYPE_LEVEL_HIGH>;
>  		interrupt-names = "DE", "SE";
> -		clocks = <&dpclk 0>, <&clockgen 2 2>, <&clockgen 2 2>,
> +		clocks = <&dpclk>, <&clockgen 2 2>, <&clockgen 2 2>,
>  			 <&clockgen 2 2>;
>  		clock-names = "pxlclk", "mclk", "aclk", "pclk";
>  		arm,malidp-output-port-lines = /bits/ 8 <8 8 8>;
> -- 
> 2.17.1
>