linux-kernel - Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191007135636.GA42880@e119886-lin.cambridge.arm.com>
Date:   Mon, 7 Oct 2019 14:56:37 +0100
From:   Andrew Murray <andrew.murray@....com>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Tom Joseph <tjoseph@...ence.com>, linux-pci@...r.kernel.org,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI:cadence:Driver refactored to use as a core library.

On Tue, Oct 01, 2019 at 04:49:12PM -0500, Bjorn Helgaas wrote:
> On Tue, Oct 01, 2019 at 11:07:28AM +0100, Andrew Murray wrote:
> > Hi Tom,
> > 
> > Thanks for the patch.
> > 
> > I'd suggest that you rename the subject of this series to "PCI: cadence: ..."
> > to be consistent with the existing commit history, e.g. git log 
> > --oneline drivers/pci/controller/pcie-cadence* - you'll also see that you
> > don't need a full stop at the end, and you ought to also change the tense
> > of the subject, e.g. Refactor driver to ...
> > 
> > See comments inline...
> 
> Andrew, thank you very much for your detailed and thoughtful reviews
> here and elsewhere.  It is a huge help.
> 

Thanks no problem, it's a pleasure :)

Thanks,

Andrew Murray

> Bjorn