linux-kernel - Re: [PATCH][next] crypto: inside-secure: fix spelling mistake "algorithmn" -> "algorithm"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 08 Oct 2019 01:28:45 -0700
From:   Joe Perches <joe@...ches.com>
To:     Pascal Van Leeuwen <pvanleeuwen@...imatrix.com>,
        Colin King <colin.king@...onical.com>,
        Antoine Tenart <antoine.tenart@...tlin.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S . Miller" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Cc:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] crypto: inside-secure: fix spelling mistake
 "algorithmn" -> "algorithm"

On Tue, 2019-10-08 at 08:15 +0000, Pascal Van Leeuwen wrote:
> > There is a spelling mistake in a dev_err message. Fix it.
[]
> > diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-
[]
> > @@ -437,7 +437,7 @@ static int safexcel_aead_setkey(struct crypto_aead *ctfm, const u8 *key,
> >  			goto badkey;
> >  		break;
> >  	default:
> > -		dev_err(priv->dev, "aead: unsupported hash algorithmn");
> > +		dev_err(priv->dev, "aead: unsupported hash algorithm");
> >  		goto badkey;
> >  	}
[]
> Actually, the typing error is well spotted, but the fix is not correct.
> What actually happened here is that a \ got accidentally deleted,
> there should have been a "\n" at the end of the line ...

Other missing newlines in the same file:
---
 drivers/crypto/inside-secure/safexcel_cipher.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c
index cecc56073337..47fec8a0a4e1 100644
--- a/drivers/crypto/inside-secure/safexcel_cipher.c
+++ b/drivers/crypto/inside-secure/safexcel_cipher.c
@@ -695,21 +695,21 @@ static int safexcel_send_req(struct crypto_async_request *base, int ring,
 		sreq->nr_dst = sreq->nr_src;
 		if (unlikely((totlen_src || totlen_dst) &&
 		    (sreq->nr_src <= 0))) {
-			dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!",
+			dev_err(priv->dev, "In-place buffer not large enough (need %d bytes)!\n",
 				max(totlen_src, totlen_dst));
 			return -EINVAL;
 		}
 		dma_map_sg(priv->dev, src, sreq->nr_src, DMA_BIDIRECTIONAL);
 	} else {
 		if (unlikely(totlen_src && (sreq->nr_src <= 0))) {
-			dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!",
+			dev_err(priv->dev, "Source buffer not large enough (need %d bytes)!\n",
 				totlen_src);
 			return -EINVAL;
 		}
 		dma_map_sg(priv->dev, src, sreq->nr_src, DMA_TO_DEVICE);
 
 		if (unlikely(totlen_dst && (sreq->nr_dst <= 0))) {
-			dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!",
+			dev_err(priv->dev, "Dest buffer not large enough (need %d bytes)!\n",
 				totlen_dst);
 			dma_unmap_sg(priv->dev, src, sreq->nr_src,
 				     DMA_TO_DEVICE);