linux-kernel - Re: [PATCH] proc:fix confusing macro arg name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <5c66196346aa47d7a252a8c0dd67ae84@huawei.com>
Date:   Tue, 8 Oct 2019 08:28:51 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     "Li, Aubrey" <aubrey.li@...ux.intel.com>
CC:     "adobriyan@...il.com" <adobriyan@...il.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dhowells@...hat.com" <dhowells@...hat.com>,
        "cyphar@...har.com" <cyphar@...har.com>,
        "christian@...uner.io" <christian@...uner.io>,
        Mingfangsen <mingfangsen@...wei.com>,
        "mm-commits@...r.kernel.org" <mm-commits@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] proc:fix confusing macro arg name


On 2019/10/8 15:05, Aubrey wrote:
>> On 2019/10/8 14:44, linmiaohe wrote:
>>  state_size and ops are in the wrong position, fix it.
>> 
> 
> Good catch!
> 
> This is interesting, I saw this interface has 50+ callers, How did they work before? ;)
>

This confused me too. The args of function proc_create_net_single is consistent with
the callers, so it works. But the wrong args name in macro proc_create_net makes
it confusing.

Thanks, have a nice day!

> Thanks,
> -Aubrey
>