linux-kernel - Re: [PATCH] ARM: dts: am3874-iceboard: Fix 'i2c-mux-idle-disconnect' usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Oct 2019 07:16:59 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Graeme Smecher <gsmecher@...eespeedlogic.com>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-omap@...r.kernel.org,
        Benoît Cousson <bcousson@...libre.com>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: am3874-iceboard: Fix 'i2c-mux-idle-disconnect'
 usage

* Graeme Smecher <gsmecher@...eespeedlogic.com> [191004 23:53]:
> Hi Andrey,
> 
> On 2019-10-03 6:45 p.m., Andrey Smirnov wrote:
> > According to
> > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
> > i2c-mux-idle-disconnect is a property of a parent node since it
> > pertains to the mux/switch as a whole, so move it there and drop all
> > of the concurrences in child nodes.
> > 
> > Fixes: d031773169df ("ARM: dts: Adds device tree file for McGill's IceBoard, based on TI AM3874")
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> > Cc: Benoît Cousson <bcousson@...libre.com>
> > Cc: Tony Lindgren <tony@...mide.com>
> > Cc: Graeme Smecher <gsmecher@...eespeedlogic.com>
> > Cc: linux-omap@...r.kernel.org
> > Cc: devicetree@...r.kernel.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> > 
> > This is purely a drive-by fix, since it concerns the HW I've never
> > heard of before. However I was working with PCA9548
> > (vf610-zii-scu4-aib is my HW) and looking at various users in the
> > kernel, when this code caught my eye. Apologies for the noise if this
> > fix is somehow bogus.
> > 
> > In case that it matters this patch is based on top of 5.4-rc1.
> 
> Thanks! We do have I2C address collisions on downstream bus segments, so
> keeping these segments isolated is important. I'm surprised this patch
> was necessary and happy to see it.
> 
> Lightly tested on 5.3.
> 
> Tested-by: Graeme Smecher <gsmecher@...eespeedlogic.com>

Applying into fixes thanks.

Tony