linux-kernel - Re: [PATCH linux-kselftest-test 2/3] kunit: allow kunit to be loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191008145552.GS32742@smile.fi.intel.com>
Date:   Tue, 8 Oct 2019 17:55:52 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Alan Maguire <alan.maguire@...cle.com>
Cc:     linux-kselftest@...r.kernel.org, brendanhiggins@...gle.com,
        skhan@...uxfoundation.org, mcgrof@...nel.org,
        keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org, yamada.masahiro@...ionext.com,
        catalin.marinas@....com, joe.lawrence@...hat.com,
        penguin-kernel@...ove.sakura.ne.jp, schowdary@...dia.com,
        urezki@...il.com, changbin.du@...el.com,
        kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Knut Omang <knut.omang@...cle.com>
Subject: Re: [PATCH linux-kselftest-test 2/3] kunit: allow kunit to be loaded
 as a module

On Tue, Oct 08, 2019 at 03:43:51PM +0100, Alan Maguire wrote:
> Making kunit itself buildable as a module allows for "always-on"
> kunit configuration; specifying CONFIG_KUNIT=m means the module
> is built but only used when loaded.  Kunit test modules will load
> kunit.ko as an implicit dependency, so simply running
> "modprobe my-kunit-tests" will load the tests along with the kunit
> module and run them.

> +#ifdef MODULE

> +#endif /* MODULE */

This is strange. Why do you need ifdef?

-- 
With Best Regards,
Andy Shevchenko