linux-kernel - Re: [PATCH linux-kselftest-test 2/3] kunit: allow kunit to be loaded as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.1910081611050.839@dhcp-10-175-191-48.vpn.oracle.com>
Date:   Tue, 8 Oct 2019 16:15:09 +0100 (BST)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
cc:     Alan Maguire <alan.maguire@...cle.com>,
        linux-kselftest@...r.kernel.org, brendanhiggins@...gle.com,
        skhan@...uxfoundation.org, mcgrof@...nel.org,
        keescook@...omium.org, yzaikin@...gle.com,
        akpm@...ux-foundation.org, yamada.masahiro@...ionext.com,
        catalin.marinas@....com, joe.lawrence@...hat.com,
        penguin-kernel@...ove.sakura.ne.jp, schowdary@...dia.com,
        urezki@...il.com, changbin.du@...el.com,
        kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Knut Omang <knut.omang@...cle.com>,
        rdunlap@...radead.org
Subject: Re: [PATCH linux-kselftest-test 2/3] kunit: allow kunit to be loaded
 as a module

On Tue, 8 Oct 2019, Andy Shevchenko wrote:

> On Tue, Oct 08, 2019 at 03:43:51PM +0100, Alan Maguire wrote:
> > Making kunit itself buildable as a module allows for "always-on"
> > kunit configuration; specifying CONFIG_KUNIT=m means the module
> > is built but only used when loaded.  Kunit test modules will load
> > kunit.ko as an implicit dependency, so simply running
> > "modprobe my-kunit-tests" will load the tests along with the kunit
> > module and run them.
> 
> > +#ifdef MODULE
> 
> > +#endif /* MODULE */
> 
> This is strange. Why do you need ifdef?
>

Ah, this was an incorrect assumption on my part; I thought that
declaring a module license for built-in code might trigger a warning 
during build. I'll remove the #ifdef MODULE around licenses in v3 (v2 has 
already gone out as I mistakenly initially sent the wrong version of the 
patches). I've verified that removing it triggers no warnings.

Thanks to you and Randy for spotting this!

Alan

> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 
>