linux-kernel - Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191008170259.GI5610@atomide.com>
Date:   Tue, 8 Oct 2019 10:02:59 -0700
From:   Tony Lindgren <tony@...mide.com>
To:     Jeroen Hofstee <jhofstee@...tronenergy.com>
Cc:     Grygorii Strashko <grygorii.strashko@...com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        Koen Kooi <koen@...inion.thruhere.net>,
        Benoît Cousson <bcousson@...libre.com>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: dts: am335x-sancloud-bbe: Fix PHY mode for ethernet

* Jeroen Hofstee <jhofstee@...tronenergy.com> [191008 17:00]:
> Hi,
> 
> On 10/8/19 6:51 PM, Tony Lindgren wrote:
> > * Jeroen Hofstee <jhofstee@...tronenergy.com> [191008 16:43]:
> >> Hello Tony,
> >>
> >> On 10/8/19 6:14 PM, Tony Lindgren wrote:
> >>> * Jeroen Hofstee <jhofstee@...tronenergy.com> [191008 16:03]:
> >>>> Hello Tony,
> >>>>
> >>>> On 10/8/19 4:23 PM, Tony Lindgren wrote:
> >>>>> * Grygorii Strashko <grygorii.strashko@...com> [191003 02:32]:
> >>>>>> On 03/10/2019 11:16, Jeroen Hofstee wrote:
> >>>>>>> Furthermore 4.19 is fine, so there is no need to include it in stable
> >>>>>>> and have a note to make sure also other patches are required etc.
> >>>>>> Hence all above patches went in 5.1 it would be correct to mention only
> >>>>>> 6d4cd041f0af net: phy: at803x: disable delay only for RGMII mode
> >>>>> Jeroen, can you please send an updated patch with the fixes
> >>>>> tag changed?
> >>>>>
> >>>> For completeness, there is no "Fixes tag" as you mentioned.
> >>>> The commit only refers to another commit which introduces
> >>>> a problem.
> >>> Well please add the fixes tag, that way this will get
> >>> properly applied to earlier stable kernels too :)
> >> But 4.19 is fine, this is an issue in 5.1 as in EOL...
> >> I really don't understand why I should waste time
> >> to figure out what happened exactly during the 5.1
> >> release cycle...
> > Hmm so what's the issue with just adding the fixes tag Grygorii
> > suggested:
> >
> > 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> >
> > No need to dig further?
> 
> Grygorii doesn't suggest to add a fixes tag, just to change the referenced
> commit to another. Obviously I would like to understand why another commit
> should be referenced. And then I should read and parse the response, so there
> is no special reason, just time...

OK sure. Well once you guys have the commit figured out, let me
know what to apply. And we know Grygorii is mostly right based
on his history of comments so best to not ignore that :)

Cheers,

Tony