linux-kernel - Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191009022815.GI5670@b29397-desktop>
Date:   Wed, 9 Oct 2019 02:28:31 +0000
From:   Peter Chen <peter.chen@....com>
To:     Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:     Pawel Laszczak <pawell@...ence.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "rogerq@...com" <rogerq@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jbergsagel@...com" <jbergsagel@...com>,
        "nsekhar@...com" <nsekhar@...com>, "nm@...com" <nm@...com>,
        "sureshp@...ence.com" <sureshp@...ence.com>,
        "kurahul@...ence.com" <kurahul@...ence.com>
Subject: Re: [PATCH] usb:cdns3: Fix for CV CH9 running with g_zero driver.

On 19-10-08 15:58:57, Felipe Balbi wrote:
> 
> Hi,
> 
> Peter Chen <peter.chen@....com> writes:
> > On 19-10-07 07:39:11, Pawel Laszczak wrote:
> >> Patch fixes issue with Halt Endnpoint Test observed
> >
> > %s/Endnpoint/Endpoint
> >
> >>
> >> during using g_zero
> >> driver as DUT. Bug occurred only on some testing board.
> >
> > g_zero is legacy, please use configfs function source_sink or loopback
> > instead.
> 
> We still want fixes for those ;-)

Yes, g_zero also uses source_sink and loopback, we just suggest the user
configfs instead of legacy modules.

> 
> >> Endpoint can defer transition to Halted state if endpoint has pending
> >> requests.
> >
> > The implementation of halt handling is a little complicated, you may
> > consider return -EAGAIN for functional stall through usb_ep_set_halt
> > from function driver if the requests are pending, it doesn't need to
> > defer such kinds of functional stall.
> 
> -EAGAIN, IIRC is only supposed to be used for IN endpoint stalls.
> 

Yes, you are right.

-- 

Thanks,
Peter Chen