linux-kernel - Re: [PATCH v2] rtc: Fix the AltCentury value on AMD/Hygon platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Oct 2019 03:18:07 +0000
From:   Jinke Fan <fanjinke@...on.cn>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
CC:     "a.zummo@...ertech.it" <a.zummo@...ertech.it>,
        Wen Pu <puwen@...on.cn>,
        "thomas.lendacky@....com" <thomas.lendacky@....com>,
        "kim.phillips@....com" <kim.phillips@....com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] rtc: Fix the AltCentury value on AMD/Hygon platform

On 2019/10/8 17:44, Alexandre Belloni wrote:
> On 08/10/2019 17:37:12+0800, Jinke Fan wrote:
>> When using following operations:
>>   	save_control = CMOS_READ(RTC_CONTROL);
>> -	CMOS_WRITE((save_control|RTC_SET), RTC_CONTROL);
>> +	CMOS_WRITE((save_control | RTC_SET), RTC_CONTROL);
> 
> Unrelated change.

OK, this line change will be cancelled in the patch v3.

>>   	save_freq_select = CMOS_READ(RTC_FREQ_SELECT);
>> -	CMOS_WRITE((save_freq_select|RTC_DIV_RESET2), RTC_FREQ_SELECT);
>> +
>> +#if defined(CONFIG_CPU_SUP_AMD) || defined(CONFIG_CPU_SUP_HYGON)
>> +	CMOS_WRITE((save_freq_select & (~RTC_DV0)), RTC_FREQ_SELECT);
> 
> That does break all the other x86 platforms.

Yes, it's a mistake. In the patch v3, the modifications will be
limited to AMD/Hygon vendor id.

-- 
Best Regards,
Jinke Fan