linux-kernel - Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20191011103710.6c45fdbc9a05fdd13177193e@suse.de>
Date:   Fri, 11 Oct 2019 10:37:10 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Jonathan Corbet <corbet@....net>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        "David S. Miller" <davem@...emloft.net>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        netdev@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH v9 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

On Thu, 10 Oct 2019 20:00:02 -0700
Jakub Kicinski <jakub.kicinski@...ronome.com> wrote:

> On Thu, 10 Oct 2019 16:59:49 +0200, Thomas Bogendoerfer wrote:
> >  	dev = alloc_etherdev(sizeof(struct ioc3_private));
> > -	if (!dev) {
> > -		err = -ENOMEM;
> > -		goto out_disable;
> > -	}
> > -
> > -	if (pci_using_dac)
> > -		dev->features |= NETIF_F_HIGHDMA;
> 
> Looks like the NETIF_F_HIGHDMA feature will not longer be set, is that
> okay?

yes, all platforms where ioc3 is usable are running 64bit kernels without
HIGHMEM.

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer