[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20191011112804.ef8079aa9bad5c81ce473fbd@suse.de>
Date: Fri, 11 Oct 2019 11:28:04 +0200
From: Thomas Bogendoerfer <tbogendoerfer@...e.de>
To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc: Jakub Kicinski <jakub.kicinski@...ronome.com>,
Jonathan Corbet <corbet@....net>,
Ralf Baechle <ralf@...ux-mips.org>,
Paul Burton <paul.burton@...s.com>,
James Hogan <jhogan@...nel.org>,
Lee Jones <lee.jones@...aro.org>,
"David S. Miller" <davem@...emloft.net>,
Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jslaby@...e.com>, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
netdev@...r.kernel.org, linux-rtc@...r.kernel.org,
linux-serial@...r.kernel.org
Subject: Re: [PATCH v9 5/5] MIPS: SGI-IP27: Enable ethernet phy on second
Origin 200 module
On Thu, 10 Oct 2019 19:37:15 +0300
Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
> On 10/10/2019 05:59 PM, Thomas Bogendoerfer wrote:
> > + /* enable ethernet PHY on IP29 systemboard */
> > + pci_read_config_dword(dev, PCI_SUBSYSTEM_VENDOR_ID, &sid);
> > + if (sid == ((PCI_VENDOR_ID_SGI << 16) | IOC3_SUBSYS_IP29_SYSBOARD))
>
> I thought PCI was little endian, thuis vendor ID at offset 0 and device ID
> at offset 2?
you are right. I already messed it up in pci-xtalk-bridge.c. As this is just a
fake sub device id, there is no harm, but I'll fix it.
Thomas.
--
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer
Powered by blists - more mailing lists