linux-kernel - Re: [PATCH] acpi: Mute gcc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de8c201d-8a73-2b3f-fe1f-19d40e2ca77d@oracle.com>
Date:   Sat, 12 Oct 2019 16:35:43 +0800
From:   Zhenzhong Duan <zhenzhong.duan@...cle.com>
To:     linux-kernel@...r.kernel.org
Cc:     Josh Boyer <jwboyer@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Chao Fan <fanc.fnst@...fujitsu.com>
Subject: Re: [PATCH] acpi: Mute gcc warning

It's been a while on this patch，still see this warning in daily build.
Will anybody be willing to review it? :)

Thanks
Zhenzhong

On 2019/9/29 9:13, Zhenzhong Duan wrote:
> When build with "EXTRA_CFLAGS=-Wall" gcc warns:
>
> arch/x86/boot/compressed/acpi.c:29:30: warning: get_cmdline_acpi_rsdp defined but not used [-Wunused-function]
>
> Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@...cle.com>
> Cc: Josh Boyer <jwboyer@...hat.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Chao Fan <fanc.fnst@...fujitsu.com>
> ---
>   arch/x86/boot/compressed/acpi.c | 48 ++++++++++++++++++++---------------------
>   1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
> index 149795c..25019d4 100644
> --- a/arch/x86/boot/compressed/acpi.c
> +++ b/arch/x86/boot/compressed/acpi.c
> @@ -21,30 +21,6 @@
>   struct mem_vector immovable_mem[MAX_NUMNODES*2];
>   
>   /*
> - * Max length of 64-bit hex address string is 19, prefix "0x" + 16 hex
> - * digits, and '\0' for termination.
> - */
> -#define MAX_ADDR_LEN 19
> -
> -static acpi_physical_address get_cmdline_acpi_rsdp(void)
> -{
> -	acpi_physical_address addr = 0;
> -
> -#ifdef CONFIG_KEXEC
> -	char val[MAX_ADDR_LEN] = { };
> -	int ret;
> -
> -	ret = cmdline_find_option("acpi_rsdp", val, MAX_ADDR_LEN);
> -	if (ret < 0)
> -		return 0;
> -
> -	if (kstrtoull(val, 16, &addr))
> -		return 0;
> -#endif
> -	return addr;
> -}
> -
> -/*
>    * Search EFI system tables for RSDP.  If both ACPI_20_TABLE_GUID and
>    * ACPI_TABLE_GUID are found, take the former, which has more features.
>    */
> @@ -298,6 +274,30 @@ acpi_physical_address get_rsdp_addr(void)
>   }
>   
>   #if defined(CONFIG_RANDOMIZE_BASE) && defined(CONFIG_MEMORY_HOTREMOVE)
> +/*
> + * Max length of 64-bit hex address string is 19, prefix "0x" + 16 hex
> + * digits, and '\0' for termination.
> + */
> +#define MAX_ADDR_LEN 19
> +
> +static acpi_physical_address get_cmdline_acpi_rsdp(void)
> +{
> +	acpi_physical_address addr = 0;
> +
> +#ifdef CONFIG_KEXEC
> +	char val[MAX_ADDR_LEN] = { };
> +	int ret;
> +
> +	ret = cmdline_find_option("acpi_rsdp", val, MAX_ADDR_LEN);
> +	if (ret < 0)
> +		return 0;
> +
> +	if (kstrtoull(val, 16, &addr))
> +		return 0;
> +#endif
> +	return addr;
> +}
> +
>   /* Compute SRAT address from RSDP. */
>   static unsigned long get_acpi_srat_table(void)
>   {