linux-kernel - Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1910121551090.15982@ninjahub.org>
Date:   Sat, 12 Oct 2019 16:00:59 +0100 (BST)
From:   Jules Irenge <jbi.octave@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>
cc:     Jules Irenge <jbi.octave@...il.com>,
        outreachy-kernel@...glegroups.com, gregkh@...uxfoundation.org,
        eric@...olt.net, wahrenst@....net, linux-kernel@...r.kernel.org,
        devel@...verdev.osuosl.org, linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org, daniela.mormocea@...il.com,
        dave.stevenson@...pberrypi.org, hverkuil-cisco@...all.nl,
        mchehab+samsung@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        sbranden@...adcom.com, rjui@...adcom.com, f.fainelli@...il.com
Subject: Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning
 of Logical continuations should be on the previous line



On Fri, 11 Oct 2019, Julia Lawall wrote:

>
>
> On Fri, 11 Oct 2019, Jules Irenge wrote:
>
>> Fix warning of logical continuations should be on the previous line.
>> Issue detected by checkpatch tool.
>
> There seem to be several changes mixed together in this patch.
>
> Don't have a subject line that is identical to a line in the log message.
> The subject line should be short.
>
> Keeping the arguments of && on the same line, but breaking the line after
> a == doesn't seem to be a good idea.  It would be better to have the left
> argument of == on one line and the right argument on another, if that is
> needed.
>
> julia
>

Apology,
Yesterday was my bday, I was reckless.
I am resending now. Please do not hesitate to give me a feedback if 
possible.
Thanks
Jules