linux-kernel - Re: net: tulip: de2104x: Checking a kmemdup() call in de21041_get_srom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191012172055.GA22569@t470p.stackframe.org>
Date:   Sat, 12 Oct 2019 19:20:55 +0200
From:   Sven Schnelle <svens@...ckframe.org>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     netdev@...r.kernel.org, linux-parisc@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Yang Wei <yang.wei9@....com.cn>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org, Aditya Pakki <pakki001@....edu>,
        Kangjie Lu <kjlu@....edu>, Navid Emamdoost <emamd001@....edu>,
        Stephen McCamant <smccaman@....edu>
Subject: Re: net: tulip: de2104x: Checking a kmemdup() call in
 de21041_get_srom_info()

On Sat, Oct 12, 2019 at 07:03:09PM +0200, Markus Elfring wrote:
> Hello,
> 
> I tried another script for the semantic patch language out.
> This source code analysis approach points out that the implementation
> of the function “de21041_get_srom_info” contains still an unchecked call
> of the function “kmemdup”.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/dec/tulip/de2104x.c?id=1c0cc5f1ae5ee5a6913704c0d75a6e99604ee30a#n1940
> https://elixir.bootlin.com/linux/v5.4-rc2/source/drivers/net/ethernet/dec/tulip/de2104x.c#L1940
> 
> How do you think about to improve it?

If i have not missed a place, the only user is de_get_eeprom(), which checks
whether de->ee_data is valid. So i think although not obvious, there's no
problem here.

Regards
Sven