linux-kernel - Re: [PATCH v5 3/3] leds: Add control of the voltage/current regulator to the LED core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <291da5c4-16c0-28a4-9bd4-ba89f6f41051@gmail.com>
Date:   Sun, 13 Oct 2019 18:40:17 +0200
From:   Jacek Anaszewski <jacek.anaszewski@...il.com>
To:     Pavel Machek <pavel@....cz>
Cc:     Jean-Jacques Hiblot <jjhiblot@...com>, daniel.thompson@...aro.org,
        linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
        dmurphy@...com, tomi.valkeinen@...com
Subject: Re: [PATCH v5 3/3] leds: Add control of the voltage/current regulator
 to the LED core

On 10/13/19 2:09 PM, Pavel Machek wrote:
> Hi!
> 
>> I must say I'm not a big fan of this change.
>> It adds a bunch of code to the LED core and gives small
>> functionality in a reward. It may also influence maximum
>> software blinking rate, so I'd rather avoid calling
>> regulator_enable/disable when timer trigger is set.
>>
>> It will of course require more code.
>>
>> Since AFAIR Pavel was original proponent of this change then
>> I'd like to see his opinion before we move on to discussing
>> possible improvements to this patch.
> 
> Was I?

See [0]:

"For the record, I also believe regulator and enable gpio should be
handled in the core."

> Okay, this series looks quite confusing to me. First, 1/3 looks
> "interesting" (would have to analyze it way more).
> 
> Second, 3/3... So we have a LED driver _and_ a regulator? So yes, the
> chip driving a LED is usually ... voltage/current regulator. What is
> second regulator doing there? Is that a common setup?
> 
> Best regards,
> 								Pavel
> 								
> 

[0]
https://lore.kernel.org/linux-leds/20190705100851.zn2jkipj4fxq5we6@devuan/

-- 
Best regards,
Jacek Anaszewski