linux-kernel - Re: [PATCH] xhci: Don't use soft retry if slot id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8319a117-ed96-53f8-48ae-907c6c34898d@gmx.at>
Date:   Mon, 14 Oct 2019 11:17:22 +0200
From:   Bernhard Gebetsberger <bernhard.gebetsberger@....at>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xhci: Don't use soft retry if slot id > 0

Am 14.10.19 um 10:06 schrieb Mathias Nyman:
> On 13.10.2019 3.33, Bernhard Gebetsberger wrote:
>> According to the xhci specification(chapter 4.6.8.1) soft retry
>> shouldn't be used if the slot id is higher than 0. Currently some usb
>> devices break on some systems because soft retry is being used when
>> there is a transaction error, without checking the slot id.
>>
> That is not correct
>
> Specs say that soft retry should not be used if we are dealing with a
> FS/LS device behind a HS hub, this can be checked from the "TT Hub Slot ID"
> field in the slot context, which we do.
>
> In xhci all devices have a slot id, so this change would prevent
> soft retry almost completely.
>
> Specs 4.6.8.1:
> "Soft Retry attempts shall not be performed if the device is behind a
> TT in a HS Hub (i.e. TT Hub Slot ID > ‘0’)."
>
> -Mathias
Thanks for the explanation, I have misunderstood that part from the xhci

spec. Sorry.

- Bernhard