linux-kernel - Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191015074434.GU32742@smile.fi.intel.com>
Date:   Tue, 15 Oct 2019 10:44:34 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tuowen Zhao <ztuowen@...il.com>
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        AceLan Kao <acelan.kao@...onical.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Luis Chamberlain <mcgrof@...nel.org>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc

On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # save the attached .config to linux build tree
> >         GCC_VERSION=7.4.0 make.cross ARCH=sparc64 
> 
> Oops, I'm not sure how would we best fix this. Clearly the patch is not
> intended for sparc64. Maybe adding devm_ioremap_uc is rather not safe
> right now.

It seems you need a preparatory patch to satisfy sparc64.

> Although, We could declare dummies for these architectures like it has
> been for powerpc.
> 
> I just noticed another driver having this issue, and fixed with direct
> calls to ioremap_uc().
> 
> 3cc2dac5be3f2: drivers/video/fbdev/atyfb: Replace MTRR UC hole with
> strong UC

That's why I asked Luis to have a look at this :)

-- 
With Best Regards,
Andy Shevchenko