linux-kernel - Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191016125615.GI16384@42.do-not-panic.com>
Date:   Wed, 16 Oct 2019 12:56:15 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Tuowen Zhao <ztuowen@...il.com>, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org,
        AceLan Kao <acelan.kao@...onical.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc

On Tue, Oct 15, 2019 at 10:44:34AM +0300, Andy Shevchenko wrote:
> On Mon, Oct 14, 2019 at 01:15:53PM -0600, Tuowen Zhao wrote:
> > On Tue, 2019-10-15 at 02:46 +0800, kbuild test robot wrote:
> > > -O ~/bin/make.cross
> > >         chmod +x ~/bin/make.cross
> > >         # save the attached .config to linux build tree
> > >         GCC_VERSION=7.4.0 make.cross ARCH=sparc64 
> > 
> > Oops, I'm not sure how would we best fix this. Clearly the patch is not
> > intended for sparc64. Maybe adding devm_ioremap_uc is rather not safe
> > right now.
> 
> It seems you need a preparatory patch to satisfy sparc64.

Indeed, can you add that? If you are not comfortable the way to leave
behind lazy architectures is the HAS_FOO feature and then have your
driver require that or depend on the archs that support this. This
allows non-lazy architecturess to move forward with life.

  Luis