linux-kernel - Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <38f39e9e77cb4bc809a15da45d988f33cb0f7f00.camel@gmail.com>
Date:   Wed, 16 Oct 2019 11:58:48 -0600
From:   Tuowen Zhao <ztuowen@...il.com>
To:     Luis Chamberlain <mcgrof@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     lee.jones@...aro.org, linux-kernel@...r.kernel.org,
        AceLan Kao <acelan.kao@...onical.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Subject: Re: [PATCH v4 1/2] lib: devres: add a helper function for ioremap_uc

On Wed, 2019-10-16 at 12:56 +0000, Luis Chamberlain wrote:
> Indeed, can you add that? If you are not comfortable the way to leave
> behind lazy architectures is the HAS_FOO feature and then have your
> driver require that or depend on the archs that support this. This
> allows non-lazy architecturess to move forward with life.
> 
>   Luis

Upon close examination, the issue seems easy to fix. Going to submit a
new set shortly.

sparc64 and hexagon don't have ioremap_uc defined. Hexagon also doesn't
have ioremap_wc but didn't report an issue before so devm_ioremap won't
have an problem.

Interestingly tho, majority of the archs include <asm-generic/io.h>,
thus having prototypes. These two archs and a few others don't. I'm
wondering if including the prototypes is actually the recommended
practice.

Tuowen