Message-ID: <d53f3bd7-d331-33c8-5232-c8f3cc9ac708@ti.com>
Date:   Tue, 15 Oct 2019 20:30:12 +0300
From:   Peter Ujfalusi <peter.ujfalusi@...com>
To:     Rob Herring <robh@...nel.org>
CC:     <nm@...com>, <devicetree@...r.kernel.org>,
        <grygorii.strashko@...com>, <lokeshvutla@...com>,
        <j-keerthy@...com>, <linux-kernel@...r.kernel.org>,
        <t-kristo@...com>, <tony@...mide.com>, <vkoul@...nel.org>,
        <ssantosh@...nel.org>, <dmaengine@...r.kernel.org>,
        <dan.j.williams@...el.com>, <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 07/14] dt-bindings: dma: ti: Add document for K3 UDMA

Rob,

On 10/11/19 10:30 AM, Peter Ujfalusi wrote:
> 
> I have already moved the TR vs Packet mode channel selection, which does
> make sense as it was Linux's choice to use TR for certain cases.
> 
> If I move these to code then we need to have big tables
> struct psil_config am654_psil[32767] = {};
> struct psil_config j721e_psil[32767] = {};

After thinking about this a bit more, I think we can move all the PSI-L
endpoint configuration to the kernel as not all the 32767 threads are
actually in use. Sure it is going to be some amount of static data in
the kernel, but it is an acceptable compromise.

The DMA binding can look like this:

dmas = <&main_udmap 0xc400>,
       <&main_udmap 0x4400>;
dma-names = "tx", "rx";

or
dmas = <&main_udmap 0x4400 UDMA_DIR_TX>,
       <&main_udmap 0x4400 UDMA_DIR_RX>;
dma-names = "tx", "rx";

If I keep the direction.
0xc400 is destination ID, which is 0x4400 | 0x8000 as per PSI-L
specification.
In the TRM only the source threads can be found as a map (thread IDs <
0x7fff), but the binding document can cover this.

This way we don't need another dtsi file and I can create the map in the
kernel.

This will hide some details of the HW from DT, but since the PSI-L
thread configuration is static in hardware I believe it is acceptable.

However we still have uncovered features in the binding or in code, like
a case when the RX does not have access to the DMA channel, only flows.
Not sure if I should reserve the direction parameter as an indication to
this or find other way.
Basically we communicate on the given PSI-L thread without having a DMA
channel as other core is owning the channel.

What do you think?

> 
> and for each new family member a new one.
> 
> Also, if we want add DMA support for a new peripheral we would need to
> modify the kernel and the DT in sync (well, kernel first, than DT).
> 
>> Or do some combination of the above. 
> 
> What about this:
> create a new dtsi file per SoC (k3-am654-psil.dtsi, k3-k721e-psil.dtsi)
> for the PSI-L threads and inside something like this:
> 
> psil-threads: psil-threads {
> 	...
> 	/* SA2UL: 0x4000 - 0x4003 */
> 	ti,psil-config-4000 {
> 		linux,udma-mode = <UDMA_PKT_MODE>;
> 		ti,needs-epib;
> 		ti,psd-size = <64>;
> 		ti,notdpkt;
> 	};
> 
> 	ti,psil-config-4001 {
> 		linux,udma-mode = <UDMA_PKT_MODE>;
> 		ti,needs-epib;
> 		ti,psd-size = <64>;
> 		ti,notdpkt;
> 	};
> 
> 	ti,psil-config-4002 {
> 		linux,udma-mode = <UDMA_PKT_MODE>;
> 		ti,needs-epib;
> 		ti,psd-size = <64>;
> 		ti,notdpkt;
> 	};
> 
> 	...
> 	/* PDMA6 (PDMA_MCASP_G0): 0x4400 - 0x4402 */
> 	thread-4400 {
> 		ti,pdma-statictr-type = <PDMA_STATIC_TR_XY>;
> 		ti,pdma-enable-acc32;
> 		ti,pdma-enable-burst;
> 	};
> 
> 	thread-4401 {
> 		ti,pdma-statictr-type = <PDMA_STATIC_TR_XY>;
> 		ti,pdma-enable-acc32;
> 		ti,pdma-enable-burst;
> 	};
> 
> 	thread-4402 {
> 		ti,pdma-statictr-type = <PDMA_STATIC_TR_XY>;
> 		ti,pdma-enable-acc32;
> 		ti,pdma-enable-burst;
> 	};
> 
> 	...
> };
> 
> Then the binding would look like this for sa2ul:
> 
> /* tx: crypto_pnp-1, rx: crypto_pnp-1 */
> dmas = <&main_udmap 0x4000 UDMA_DIR_TX>,
>        <&main_udmap 0x4000 UDMA_DIR_RX>,
>        <&main_udmap 0x4001 UDMA_DIR_RX>;
> dma-names = "tx", "rx1", "rx2";
> 
> for McASP:
> dmas = <&main_udmap 0x4400 UDMA_DIR_TX>,
>        <&main_udmap 0x4400 UDMA_DIR_RX>;
> dma-names = "tx", "rx";
> 
> Then either we can have phandle in the udmap nodes to the psil-threads,
> or just find it from the root when needed.
> 
>> Sorry I don't have specific suggestions, but I just see lots of properties 
>> and complexity, and I don't really understand the h/w here. Putting the 
>> complexity in what is an ABI is generally not a good plan.
> 
> The complexity is coming from the hardware itself. If I can not describe
> the hardware than it is not going to be easy for the software to figure
> out what it is dealing with.
> 
>> And I don't 
>> have the bandwidth to study and understand the complexities of your h/w 
>> (and everyone elses), so just more explanations are not likely to really 
>> help.
> 
> Sure, I understand.
> 
> - Péter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

- Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

Powered by blists - more mailing lists