linux-kernel - Re: [PATCH -next 10/30] pinctrl: tegra: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191017125211.GA3768303@ulmo>
Date:   Thu, 17 Oct 2019 14:52:11 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     linus.walleij@...aro.org, manivannan.sadhasivam@...aro.org,
        afaerber@...e.de, f.fainelli@...il.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        jesper.nilsson@...s.com, lars.persson@...s.com,
        ludovic.desroches@...rochip.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, baruch@...s.co.il,
        linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...s.com,
        linux-oxnas@...ups.io, linux-renesas-soc@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-tegra@...r.kernel.org,
        vz@...ia.com, narmstrong@...libre.com, geert+renesas@...der.be,
        daniel@...que.org, haojian.zhuang@...il.com, wens@...e.org,
        jonathanh@...dia.com, agross@...nel.org
Subject: Re: [PATCH -next 10/30] pinctrl: tegra: use
 devm_platform_ioremap_resource() to simplify code

On Thu, Oct 17, 2019 at 08:26:20PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/pinctrl/tegra/pinctrl-tegra-xusb.c | 4 +---
>  drivers/pinctrl/tegra/pinctrl-tegra.c      | 3 +--
>  2 files changed, 2 insertions(+), 5 deletions(-)

Acked-by: Thierry Reding <treding@...dia.com>

> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
> index f2fa1f7..6f7b376 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra-xusb.c
> @@ -873,7 +873,6 @@ int tegra_xusb_padctl_legacy_probe(struct platform_device *pdev)
>  {
>  	struct tegra_xusb_padctl *padctl;
>  	const struct of_device_id *match;
> -	struct resource *res;
>  	struct phy *phy;
>  	int err;
>  
> @@ -894,8 +893,7 @@ int tegra_xusb_padctl_legacy_probe(struct platform_device *pdev)
>  	match = of_match_node(tegra_xusb_padctl_of_match, pdev->dev.of_node);
>  	padctl->soc = match->data;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	padctl->regs = devm_ioremap_resource(&pdev->dev, res);
> +	padctl->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(padctl->regs))
>  		return PTR_ERR(padctl->regs);
>  
> diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
> index e9a7cbb..692d8b3 100644
> --- a/drivers/pinctrl/tegra/pinctrl-tegra.c
> +++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
> @@ -781,8 +781,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev,
>  		return -ENOMEM;
>  
>  	for (i = 0; i < pmx->nbanks; i++) {
> -		res = platform_get_resource(pdev, IORESOURCE_MEM, i);
> -		pmx->regs[i] = devm_ioremap_resource(&pdev->dev, res);
> +		pmx->regs[i] = devm_platform_ioremap_resource(pdev, i);
>  		if (IS_ERR(pmx->regs[i]))
>  			return PTR_ERR(pmx->regs[i]);
>  	}
> -- 
> 2.7.4
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)