linux-kernel - Re: [PATCH] drm/amdgpu/display: fix compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8a7cb551-5f1c-c37d-97a6-53c62ebee7ee@amd.com>
Date:   Thu, 17 Oct 2019 17:30:28 +0000
From:   "Li, Sun peng (Leo)" <Sunpeng.Li@....com>
To:     Chen Wandun <chenwandun@...wei.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/amdgpu/display: fix compile error

This has already been fixed here:
https://patchwork.freedesktop.org/patch/336195/

Should be mirrored on Alex's tree soon.

Thanks,
Leo

On 2019-10-17 2:19 a.m., Chen Wandun wrote:
> From: Chenwandun <chenwandun@...wei.com>
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1913:48: error: struct dc_crtc_timing_flags has no member named DSC
>    if (res_ctx->pipe_ctx[i].stream->timing.flags.DSC)
> 						^
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn20/dcn20_resource.c:1914:73: error: struct dc_crtc_timing has no member named dsc_cfg
>    pipes[pipe_cnt].dout.output_bpp = res_ctx->pipe_ctx[i].stream->timing.dsc_cfg.bits_per_pixel / 16.0;
> 									^
> Signed-off-by: Chenwandun <chenwandun@...wei.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> index 914e378..4f03318 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> @@ -1910,8 +1910,10 @@ int dcn20_populate_dml_pipes_from_context(
>  			pipes[pipe_cnt].dout.output_bpp = output_bpc * 3;
>  		}
>  
> +#ifdef CONFIG_DRM_AMD_DC_DSC_SUPPORT
>  		if (res_ctx->pipe_ctx[i].stream->timing.flags.DSC)
>  			pipes[pipe_cnt].dout.output_bpp = res_ctx->pipe_ctx[i].stream->timing.dsc_cfg.bits_per_pixel / 16.0;
> +#endif
>  
>  		/* todo: default max for now, until there is logic reflecting this in dc*/
>  		pipes[pipe_cnt].dout.output_bpc = 12;
>