linux-kernel - Re: [PATCH 1/2] x86/cpu/vmware: Use the full form of INL in VMWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Oct 2019 09:28:58 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Thomas Hellström (VMware) 
        <thomas_os@...pmail.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Thomas Hellstrom <thellstrom@...are.com>,
        Sami Tolvanen <samitolvanen@...gle.com>,
        clang-built-linux <clang-built-linux@...glegroups.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>, x86-ml <x86@...nel.org>,
        Borislav Petkov <bp@...e.de>
Subject: Re: [PATCH 1/2] x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL

On Fri, Oct 18, 2019 at 6:41 AM Thomas Hellström (VMware)
<thomas_os@...pmail.org> wrote:
>
> From: Thomas Hellstrom <thellstrom@...are.com>
>
> LLVM's assembler doesn't accept the short form INL instruction:
>
>   inl (%%dx)
>
> but instead insists on the output register to be explicitly specified.
>
> This was previously fixed for the VMWARE_PORT macro. Fix it also for
> the VMWARE_HYPERCALL macro.
>
> Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions")
> Suggested-by: Sami Tolvanen <samitolvanen@...gle.com>
> Signed-off-by: Thomas Hellstrom <thellstrom@...are.com>

Thank you for the patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> Cc: clang-built-linux@...glegroups.com
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: x86-ml <x86@...nel.org>
> Cc: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/include/asm/vmware.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/vmware.h b/arch/x86/include/asm/vmware.h
> index e00c9e875933..f5fbe3778aef 100644
> --- a/arch/x86/include/asm/vmware.h
> +++ b/arch/x86/include/asm/vmware.h
> @@ -29,7 +29,8 @@
>
>  /* The low bandwidth call. The low word of edx is presumed clear. */
>  #define VMWARE_HYPERCALL                                               \
> -       ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT ", %%dx; inl (%%dx)", \
> +       ALTERNATIVE_2("movw $" VMWARE_HYPERVISOR_PORT                   \
> +                     ", %%dx; inl (%%dx), %%eax",                      \
>                       "vmcall", X86_FEATURE_VMCALL,                     \
>                       "vmmcall", X86_FEATURE_VMW_VMMCALL)
>
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@...glegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/20191018134052.3023-2-thomas_os%40shipmail.org.



-- 
Thanks,
~Nick Desaulniers