linux-kernel - Re: [PATCH -next] btrfs: Make init_tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bab47b8e-d35f-a769-a703-4dcfe1a17980@suse.com>
Date:   Fri, 18 Oct 2019 15:09:58 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     YueHaibing <yuehaibing@...wei.com>, clm@...com,
        josef@...icpanda.com, dsterba@...e.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] btrfs: Make init_tree_roots static



On 18.10.19 г. 15:06 ч., YueHaibing wrote:
> Fix sparse warning:
> 
> fs/btrfs/disk-io.c:2534:12: warning:
>  symbol 'init_tree_roots' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Huhz, I thought I had added static... Anyway this could be folded in the
original patch. Thanks for the report.

> ---
>  fs/btrfs/disk-io.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
> index d078276..cb187f5 100644
> --- a/fs/btrfs/disk-io.c
> +++ b/fs/btrfs/disk-io.c
> @@ -2531,7 +2531,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info,
>  	return ret;
>  }
>  
> -int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
> +static int __cold init_tree_roots(struct btrfs_fs_info *fs_info)
>  {
>  	int backup_index = find_newest_super_backup(fs_info);
>  	struct btrfs_super_block *sb = fs_info->super_copy;
>