linux-kernel - Re: [PATCH v4 00/16] Rewrite x86/ftrace to use text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021090922.GA41231@gmail.com>
Date:   Mon, 21 Oct 2019 11:09:22 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Peter Zijlstra <peterz@...radead.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org, rostedt@...dmis.org,
        mhiramat@...nel.org, bristot@...hat.com, jbaron@...mai.com,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        namit@...are.com, hpa@...or.com, luto@...nel.org,
        ard.biesheuvel@...aro.org, jpoimboe@...hat.com, jeyu@...nel.org
Subject: Re: [PATCH v4 00/16] Rewrite x86/ftrace to use text_poke (and more)


* Peter Zijlstra <peterz@...radead.org> wrote:

> Ftrace was one of the last W^X violators (and KLP it seems). These here patches
> move it over to the generic text_poke() interface and thereby get rid of this
> oddity.
> 
> The first 6 or so patches are more or less the same as in v3, except it has the
> bugs fixed that Steve found:
> 
>  - boot time function tracing works
>  - module loading with function tracing works
> 
> Then there's 10 new patches, that go all over the place, mostly inspired by
> staring at code touched by the first 6. That is, there's further ftrace and
> kprobes cleanups, as well fixes for various issues.
> 
> In the end, it will have removed the horrible set_all_modules_text_*()
> interface and reduced the ftrace module loading to a single callback (again).
> 
> The ARM patch is compiled only, I would be much obliged if someone could test
> that.

Ok, this looks all around like a nice improvement to me, and fixes a few 
bugs as well.

Steve, any objections to this series? If not I'll stick it into 
tip:core/kprobes with a tentative v5.5 upstream merge target.

Thanks,

	Ingo