linux-kernel - Re: [PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191021093839.GM32742@smile.fi.intel.com>
Date:   Mon, 21 Oct 2019 12:38:39 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Anatol Belski <weltling@...look.de>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Michael Jamet <michael.jamet@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        "trivial@...nel.org" <trivial@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2] include/linux/byteorder/generic.h: fix
 signed/unsigned warnings

On Mon, Oct 21, 2019 at 09:27:37AM +0000, Anatol Belski wrote:
> From: Anatol Belski <anbelski@...rosoft.com>
> 
> This fixes the warnings like below, thrown by GCC
> 
> warning: comparison of integer expressions of different signedness: \
> ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
>   195 |  for (i = 0; i < len; i++)
>       |                ^

We have explicitly disabled this warnings in the kernel Makefile.
How did you achieve this? (yes, I know the possible answer, perhaps
this has to be mentioned as well)

Now I see some inconsistency with this warning between GCC and Clang. Add
related people to the discussion.

> Signed-off-by: Anatol Belski <anbelski@...rosoft.com>
> ---

Changelog is missing.
(No need to resend just for this, it's for your future contributions)

-- 
With Best Regards,
Andy Shevchenko