linux-kernel - Re: [PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR0502MB3668F50248ACD5CFA9B74D96BA690@AM0PR0502MB3668.eurprd05.prod.outlook.com>
Date:   Mon, 21 Oct 2019 10:08:00 +0000
From:   Anatol Belski <weltling@...look.de>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Michael Jamet <michael.jamet@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        "trivial@...nel.org" <trivial@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH v2] include/linux/byteorder/generic.h: fix signed/unsigned
 warnings

On Mon, 2019-10-21 at 12:38 +0300, Andy Shevchenko wrote:
> We have explicitly disabled this warnings in the kernel Makefile.
> How did you achieve this? (yes, I know the possible answer, perhaps
> this has to be mentioned as well)
Added W=12 to the make command, used GCC 9.1.0. There are quite some
warnings of this art yet, so this is just a first shot.

Additional issue i'd see in this particular case also, that iterating
through an array should use some unsigned to ensure there's no signed
overflow. But otherwise, it's better to fix similar cases to reduce the
noise.

> > Signed-off-by: Anatol Belski <anbelski@...rosoft.com>
> > ---
> 
> Changelog is missing.
> (No need to resend just for this, it's for your future contributions)
> 
Thanks for pointing to this. I also probably should have added a Cc:.
Will go through the submitting patches document more carefully.

Thanks!

anatol