linux-kernel - Re: [v2] drm/komeda: Fix typos in komeda_splitter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5882846.nLqbd4GdRz@e123338-lin>
Date:   Mon, 21 Oct 2019 14:02:56 +0000
From:   Mihail Atanassov <Mihail.Atanassov@....com>
To:     "james qian wang (Arm Technology China)" <james.qian.wang@....com>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        David Airlie <airlied@...ux.ie>,
        Liviu Dudau <Liviu.Dudau@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        nd <nd@....com>
Subject: Re: [v2] drm/komeda: Fix typos in komeda_splitter_validate

On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology China) wrote:
> On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote:
> > Fix both the string and the struct member being printed.
> > 
> > Changes since v1:
> >  - Now with a bonus grammar fix, too.
> > 
> > Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support")
> > Signed-off-by: Mihail Atanassov <mihail.atanassov@....com>
> > ---
> >  drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > index 950235af1e79..2b624bfe1751 100644
> > --- a/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c
> > @@ -564,8 +564,8 @@ komeda_splitter_validate(struct komeda_splitter *splitter,
> >  	}
> >  
> >  	if (!in_range(&splitter->vsize, dflow->in_h)) {
> > -		DRM_DEBUG_ATOMIC("split in_in: %d exceed the acceptable range.\n",
> > -				 dflow->in_w);
> > +		DRM_DEBUG_ATOMIC("split in_h: %d exceeds the acceptable range.\n",
> > +				 dflow->in_h);
> 
> Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@....com>

Thanks for the review, applied to drm-misc-fixes -
8ae501e295cce9bc6e0dd82d5204a1d5faef44f8.

> >  		return -EINVAL;
> >  	}
> >  
> 


-- 
Mihail