linux-kernel - adv748x: missing parens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+ZMxcvnZnDa=uYyaLQaW5r22vBpXkDuMU=CM2BVzjF_Tg@mail.gmail.com>
Date:   Tue, 22 Oct 2019 09:29:16 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     kieran.bingham@...asonboard.com, mchehab@...nel.org,
        linux-media@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Subject: adv748x: missing parens

Hi Kieran,

Building kernel with clang gives me:

drivers/media/i2c/adv748x/adv748x-afe.c:452:12: warning: operator '?:'
has lower precedence than '|'; '|' will be evaluated first
[-Wbitwise-conditional-parentheses]

ret = sdp_clrset(state, ADV748X_SDP_FRP, ADV748X_SDP_FRP_MASK, enable
? ctrl->val - 1 : 0);
#define sdp_clrset(s, r, m, v) sdp_write(s, r, (sdp_read(s, r) & ~m) | v)

This is on linux-next commit a722f75b2923b4fd44c17e7255e822ac48fe85f0
Date:   Tue Oct 22 16:17:17 2019 +1100
    Add linux-next specific files for 20191022

It seems sdp_clrset needs some more parens.